[ 
https://issues.apache.org/jira/browse/SCM-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962903#comment-17962903
 ] 

ASF GitHub Bot commented on SCM-763:
------------------------------------

jira-importer commented on issue #970:
URL: https://github.com/apache/maven-scm/issues/970#issuecomment-2964636673

   **[Weston 
Bustraan](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wbustraan)**
 commented
   
   [Michael 
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o), 
you are correct, the regex does treat the ending double quote as part of the 
password in your example; you would probably need a more complex routine or 
regex to perfectly handle that. However, the string produced by the password 
masking isn't intended to actually be executed by the OS; it is just printed on 
stdout for the user to see. The goal is to prevent the password from being 
printed to the log output and I believe that it still accomplishes that goal 
better than the original implementation.
   




> Password masking for svnexe does not handle all cases
> -----------------------------------------------------
>
>                 Key: SCM-763
>                 URL: https://issues.apache.org/jira/browse/SCM-763
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.9
>         Environment: Jenkins 1.502 on a SLES11
>            Reporter: Tobias Kalmes
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Passwords are not masked in the log output on Linux machines. The masking 
> works as intended on Windows machines. On linux machines tho the password is 
> printed in clear text. This seems to be a problem due to the additional 
> single quotes that are added around the parameters on linux machines.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to