jira-importer commented on issue #984:
URL: https://github.com/apache/maven-scm/issues/984#issuecomment-2964637579

   **[Andreas 
Schaller](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=schaller)**
 commented
   
   In ValidateMojo, the field that gets the configuration value injected is 
described as unused:
   
   ```java
   @Parameter( property = "scmCheckWorkingDirectoryUrl", defaultValue = "false" 
)
   // Actually unused in the code here. Present for doc purpose,
   // see 
org.apache.maven.scm.provider.svn.AbstractSvnScmProvider.CHECK_WORKING_DIRECTORY_URL
   private boolean scmCheckWorkingDirectoryUrl;
   ```
   
   In the validateConnection-method however, the field is used to store the 
current working directory as system property.
   Wouldn't it be sufficient to also store the value of 
scmCheckWorkingDirectoryUrl as system propety at this point so that it can be 
used in AbstractSvnScmProvider?
   Not nice but should work
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to