[
https://issues.apache.org/jira/browse/SCM-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963197#comment-17963197
]
ASF GitHub Bot commented on SCM-807:
------------------------------------
jira-importer commented on issue #1037:
URL: https://github.com/apache/maven-scm/issues/1037#issuecomment-2964640285
**[Richard
DiCroce](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rcd)**
commented
It's been 7.5 months since I submitted the patch, so my memory is a bit
foggy here. But if I'm reading the patch correctly, there is still a call to
AddCommand#addFilepattern(String) in the loop, passing a path relative to the
repository root. IIRC there were two calls to addFilepattern, but JGit only
works on paths relative to the repository root, so the second call to
addFilepattern using an absolute path is completely pointless. Hence the reason
I removed it.
> JGit impl check-in fails unless the Maven project is in the working copy root
> -----------------------------------------------------------------------------
>
> Key: SCM-807
> URL: https://issues.apache.org/jira/browse/SCM-807
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
> Affects Versions: 1.9.4
> Reporter: Richard DiCroce
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0-M2
>
> Attachments: scm-807.txt
>
>
> Another problem exposed by maven-release-plugin: the JGit SCM
> implementation's check-in fails unless the Maven project is in the working
> copy root because it confuses the working copy's location with the Maven
> project's location.
> The attached patch resolves the issue. Combined with the patch attached to
> SCM-806, release:prepare now mostly succeeds with the JGit implementation.
> There is still a problem with the POM not being transformed correctly, but
> that's a problem in maven-release-plugin.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
