[
https://issues.apache.org/jira/browse/SCM-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961415#comment-17961415
]
ASF GitHub Bot commented on SCM-418:
------------------------------------
jira-importer opened a new issue, #634:
URL: https://github.com/apache/maven-scm/issues/634
**[Peter
Janes](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=peterj)**
opened
**[SCM-418](https://issues.apache.org/jira/browse/SCM-418?redirect=false)** and
commented
Continuum wasn't reporting author/date/comment for each build's modified
files when used with Perforce. I tracked the root cause to the update command
not returning the current changelist, which in turn wasn't being provided to
the changelog command. At the same time, the changelog command didn't accept
revision-based ranges, only dates.
The attached patch (with updated test cases) makes the Continuum build
status pages return full results.
The basic flow is to get the newly-submitted changelist numbers using "p4
changes", then populate ChangeSet objects directly using "p4 describe".
A side effect is that this replaces the patch for SCM-332. The original
code gathered the changed files (and their comments) with "p4 filelog", which
the patch then re-aggregated into changesets. The new version accomplishes the
same thing, but more directly.
---
**Affects:** 1.1
**Attachments:**
-
[changelog.patch](https://issues.apache.org/jira/secure/attachment/12718647/changelog.patch)
(_51.96 kB_)
-
[scm-418.patch](https://issues.apache.org/jira/secure/attachment/12718509/scm-418.patch)
(_54.97 kB_)
-
[scm-418-against-769975.patch](https://issues.apache.org/jira/secure/attachment/12718607/scm-418-against-769975.patch)
(_54.02 kB_)
> Support for Perforce changelogs in Continuum and changelog plugin
> -----------------------------------------------------------------
>
> Key: SCM-418
> URL: https://issues.apache.org/jira/browse/SCM-418
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.1
> Environment: tested on Maven 2.0.9, Continuum 1.2, Perforce 2008.1,
> all under Fedora 9
> Reporter: Peter Janes
> Assignee: Olivier Lamy
> Priority: Major
> Fix For: 1.3
>
> Attachments: changelog.patch, scm-418-against-769975.patch,
> scm-418.patch
>
>
> Continuum wasn't reporting author/date/comment for each build's modified
> files when used with Perforce. I tracked the root cause to the update
> command not returning the current changelist, which in turn wasn't being
> provided to the changelog command. At the same time, the changelog command
> didn't accept revision-based ranges, only dates.
> The attached patch (with updated test cases) makes the Continuum build status
> pages return full results.
> The basic flow is to get the newly-submitted changelist numbers using "p4
> changes", then populate ChangeSet objects directly using "p4 describe".
> A side effect is that this replaces the patch for SCM-332. The original code
> gathered the changed files (and their comments) with "p4 filelog", which the
> patch then re-aggregated into changesets. The new version accomplishes the
> same thing, but more directly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
