[
https://issues.apache.org/jira/browse/SCM-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963292#comment-17963292
]
ASF GitHub Bot commented on SCM-834:
------------------------------------
jira-importer commented on issue #1050:
URL: https://github.com/apache/maven-scm/issues/1050#issuecomment-2964642870
**[Michael
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)**
commented
Sounds reasonable but there are more spots than this:
```
Name Line Text Path
DiffMojo.java 94 FileUtils.fileWrite(
outputFile.getAbsolutePath(), result.getPatch() );
D:\Entwicklung\Projekte\maven-scm\maven-scm-plugin\src\main\java\org\apache\maven\scm\plugin
IntegrityDiffCommand.java 90 // a NPE in
org.codehaus.plexus.util.FileUtils.fileWrite(FileUtils.java:426)
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-provider-integrity\src\main\java\org\apache\maven\scm\provider\integrity\command\diff
AbstractCvsCheckInCommand.java 73
FileUtils.fileWrite( messageFile.getAbsolutePath(), message );
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-cvs\maven-scm-provider-cvs-commons\src\main\java\org\apache\maven\scm\provider\cvslib\command\checkin
GitCheckInCommand.java 74 FileUtils.fileWrite(
messageFile.getAbsolutePath(), message );
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\src\main\java\org\apache\maven\scm\provider\git\gitexe\command\checkin
GitTagCommand.java 80 FileUtils.fileWrite(
messageFile.getAbsolutePath(), scmTagParameters.getMessage() );
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\src\main\java\org\apache\maven\scm\provider\git\gitexe\command\tag
SvnBranchCommand.java 79 FileUtils.fileWrite(
messageFile.getAbsolutePath(), scmBranchParameters.getMessage() );
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\branch
SvnCheckInCommand.java 63 FileUtils.fileWrite(
messageFile.getAbsolutePath(), message );
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\checkin
SvnMkdirCommand.java 60 FileUtils.fileWrite(
messageFile.getAbsolutePath(), message );
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\mkdir
SvnTagCommand.java 103 FileUtils.fileWrite(
messageFile.getAbsolutePath(), scmTagParameters == null ? "" : scmTagParameters
D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-svn\maven-scm-provider-svnexe\src\main\java\org\apache\maven\scm\provider\svn\svnexe\command\tag
```
and `SvnCommandLineUtils#addTarget`.
We need a more general approach because this is used through entire Maven
SCM. One can either add `messageEncoding` with default value `UTF-8` or reuse
these maybe:
```xml
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
```
At least we need a stable encoding because this is internal code. `UTF-8` is
the safest bet here.
See [here](http://stackoverflow.com/a/19886198/696632) for similar problems
with Subversion.
> Commit encoding is platform-dependent instead of UTF-8
> ------------------------------------------------------
>
> Key: SCM-834
> URL: https://issues.apache.org/jira/browse/SCM-834
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-gitexe, maven-scm-provider-svn
> Affects Versions: 1.9.4
> Reporter: Tobias Gruetzmacher
> Assignee: Michael Osipov
> Priority: Blocker
> Fix For: 1.11.1
>
>
> When doing a release with the maven-release-plugin, if you have a
> non-ASCII-character in your commit message (setting scmCommentPrefix to
> "lösung" for example), the resulting commit message has a different encoding
> on different operating systems. If it isn't UTF-8 (on Windows, for example),
> git complains with
> {code}
> Warning: commit message did not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.
> {code}
> AFAICS, the fix is pretty simple: Just add "UTF-8" to the call of fileWrite
> in
> [GitCheckInCommand.java|https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java#L74]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
