[
https://issues.apache.org/jira/browse/SCM-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962746#comment-17962746
]
ASF GitHub Bot commented on SCM-721:
------------------------------------
jira-importer opened a new issue, #932:
URL: https://github.com/apache/maven-scm/issues/932
**[Richard
DiCroce](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rcd)**
opened
**[SCM-721](https://issues.apache.org/jira/browse/SCM-721?redirect=false)** and
commented
The changeLog() method does not respect the limit parameter. This appears to
happen because the limit parameter gets lost in the middle of the method chain:
1. HgScmProvider.changelog() calls AbstractCommand.execute()
2. AbstractCommand.execute() calls AbstractChangeLogCommand.executeCommand()
3. AbstractChangeLogCommand.executeCommand() calls one of two overloads of
executeChangeLogCommand(), both of which are deprecated. Neither takes a limit
parameter, and the limit parameter is lost at this point.
I encountered this problem on Mercurial, but other providers will also be
affected unless their concrete ChangeLogCommand implementations override
executeCommand() to call a method that supports the limit parameter. Curiously,
HgChangeLogCommand does have such a method, but it is never called.
---
**Affects:** 1.8.1
> Mercurial ChangeLog command doesn't respect limit
> -------------------------------------------------
>
> Key: SCM-721
> URL: https://issues.apache.org/jira/browse/SCM-721
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-mercurial (hg)
> Affects Versions: 1.8.1
> Reporter: Richard DiCroce
> Priority: Major
>
> The changeLog() method does not respect the limit parameter. This appears to
> happen because the limit parameter gets lost in the middle of the method
> chain:
> 1. HgScmProvider.changelog() calls AbstractCommand.execute()
> 2. AbstractCommand.execute() calls AbstractChangeLogCommand.executeCommand()
> 3. AbstractChangeLogCommand.executeCommand() calls one of two overloads of
> executeChangeLogCommand(), both of which are deprecated. Neither takes a
> limit parameter, and the limit parameter is lost at this point.
> I encountered this problem on Mercurial, but other providers will also be
> affected unless their concrete ChangeLogCommand implementations override
> executeCommand() to call a method that supports the limit parameter.
> Curiously, HgChangeLogCommand does have such a method, but it is never called.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
