[ 
https://issues.apache.org/jira/browse/SCM-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963754#comment-17963754
 ] 

ASF GitHub Bot commented on SCM-946:
------------------------------------

jira-importer opened a new issue, #1169:
URL: https://github.com/apache/maven-scm/issues/1169

   
**[Lonzak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tom_1st)**
 opened 
**[SCM-946](https://issues.apache.org/jira/browse/SCM-946?redirect=false)** and 
commented
   
   During our build with maven 3.5.4 we get the following warning which seem to 
indicate that the `@threadSafe` annotation has not been set for this plugin. 
   
   ```java
   [WARNING] ****************************************************************
   *17:26:25 [WARNING] * Your build is requesting parallel execution, but 
project 
   *17:26:25 [WARNING] * contains the following plugin(s) that have goals not 
marked 
   *17:26:25 [WARNING] * as @threadSafe to support parallel building. 
   *17:26:25 [WARNING] * While this /may/ work fine, please look for plugin 
updates 
   *17:26:25 [WARNING] * and/or request plugins be made thread-safe. 
   *17:26:25 [WARNING] * If reporting an issue, report it against the plugin in 
   *17:26:25 [WARNING] * question, not against maven-core 
   *17:26:25 [WARNING] 
****************************************************************
   *17:26:25 [WARNING] The following plugins are not marked @threadSafe in 
ourproject:
   *17:26:25 [WARNING] org.apache.maven.plugins:maven-scm-plugin:1.11.2
   *17:26:25 [WARNING] Enable debug to see more precisely which goals are not 
marked @threadSafe.
   *17:26:25 [WARNING] 
*****************************************************************
   ```
   
    
   
   We use the tag-release command.
   
   ```java
   <plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-scm-plugin</artifactId>
    <executions>
     <execution>
      <id>tag-release</id>
      <phase/>
      </execution>
     </executions>
    </plugin>
   ```
   
    
   
   I can not tell whether it is threadsafe but probably some project member can.
   
   If nobody can say then set it to **false** to be on the safe side,
   
   If so it should be noted in the documentation...
   
   I created a PR to illustrate a potential fix
   
   https://github.com/apache/maven-scm/pull/107
   
    
   
   Thanks
   
   
   ---
   
   **Affects:** 1.11.2
   
   **Remote Links:**
   - [GitHub Pull Request #107
   ](https://github.com/apache/maven-scm/pull/107)
   




> Making the maven-scm-plugin fit for parallel execution (@threadSafe)
> --------------------------------------------------------------------
>
>                 Key: SCM-946
>                 URL: https://issues.apache.org/jira/browse/SCM-946
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Task
>          Components: maven-plugin
>    Affects Versions: 1.11.2
>            Reporter: Lonzak
>            Assignee: Michael Osipov
>            Priority: Major
>
> During our build with maven 3.5.4 we get the following warning which seem to 
> indicate that the @threadSafe annotation has not been set for this plugin. 
> {code:java}
> [WARNING] ****************************************************************
> *17:26:25 [WARNING] * Your build is requesting parallel execution, but 
> project 
> *17:26:25 [WARNING] * contains the following plugin(s) that have goals not 
> marked 
> *17:26:25 [WARNING] * as @threadSafe to support parallel building. 
> *17:26:25 [WARNING] * While this /may/ work fine, please look for plugin 
> updates 
> *17:26:25 [WARNING] * and/or request plugins be made thread-safe. 
> *17:26:25 [WARNING] * If reporting an issue, report it against the plugin in 
> *17:26:25 [WARNING] * question, not against maven-core 
> *17:26:25 [WARNING] 
> ****************************************************************
> *17:26:25 [WARNING] The following plugins are not marked @threadSafe in 
> ourproject:
> *17:26:25 [WARNING] org.apache.maven.plugins:maven-scm-plugin:1.11.2
> *17:26:25 [WARNING] Enable debug to see more precisely which goals are not 
> marked @threadSafe.
> *17:26:25 [WARNING] 
> *****************************************************************{code}
>  
> We use the tag-release command.
> {code:java}
> <plugin>
>  <groupId>org.apache.maven.plugins</groupId>
>  <artifactId>maven-scm-plugin</artifactId>
>  <executions>
>   <execution>
>    <id>tag-release</id>
>    <phase/>
>    </execution>
>   </executions>
>  </plugin>{code}
>  
> I can not tell whether it is threadsafe but probably some project member can.
> If nobody can say then set it to *false* to be on the safe side,
> If so it should be noted in the documentation...
> I created a PR to illustrate a potential fix
> [https://github.com/apache/maven-scm/pull/107]
>  
> Thanks



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to