[ 
https://issues.apache.org/jira/browse/SCM-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963864#comment-17963864
 ] 

ASF GitHub Bot commented on SCM-981:
------------------------------------

jira-importer commented on issue #1211:
URL: https://github.com/apache/maven-scm/issues/1211#issuecomment-2964656078

   **[Niels 
Basjes](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=nielsbasjes)**
 commented
   
   Tests I know about that fail under `-Ptck`
   * 
maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/command/blame/HgBlameCommandTckTest.java
     This is never true; the revision is always a hash.
   
   ```java
   assertEquals( "0", line.getRevision() ); 
   ```
   
   * 
maven-scm-providers/maven-scm-provider-local/src/test/java/org/apache/maven/scm/provider/local/command/update/LocalUpdateCommandTckTest.java
     In the testUpdateCommand test located in the superclass 
maven-scm-test/src/main/java/org/apache/maven/scm/tck/command/update/UpdateCommandTckTest.java
 fails over 
   
   ```java
   assertPath( "src/main/java/org/Foo.java", file.getPath() );
   ```
   
   with
   
   ```java
   Expected :src/main/java/org/Foo.java
   Actual   :/src/main/java/org/Foo.java
   ```
   
    
   
    
   
    
   




> Several integration tests are never run and fail if you do
> ----------------------------------------------------------
>
>                 Key: SCM-981
>                 URL: https://issues.apache.org/jira/browse/SCM-981
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M2
>
>
> The README.md states
> {quote}Run all the tests with `mvn -Prun-its verify` to assure nothing else 
> was accidentally broken.
> {quote}
> The Github actions reuses for the CI build
> {code:java}
> apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2{code}
> which does the same
> {code:java}
> ./mvnw --errors --batch-mode --show-version -D"invoker.streamLogsOnFailures" 
> -P run-its verify{code}
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L167]
> [https://github.com/apache/maven-gh-actions-shared/blob/v2/.github/workflows/maven-verify.yml#L93]
> The snag is that this profile does not exist in this project.
> I asked this and was told to use the `tck-git` profile
> [https://github.com/apache/maven-scm/pull/134#issuecomment-1130214768]
> I found that there is also a `tck-svn` profile and a `tck` profile.
> When I run `mvn clean verify -Ptck` there are several tests that fail and are 
> apparently never run by anyone.
>  
> Proposal: 
>  * Create a profile run-its that simply activates the appropriate tck 
> profiles.
>  * Fix the failing tests.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to