[ 
https://issues.apache.org/jira/browse/SCM-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17964681#comment-17964681
 ] 

Olivier Lamy commented on SCM-504:
----------------------------------

This project has moved from Jira to GitHub Issues. This issue was migrated to 
[apache/maven-scm#718|https://github.com/apache/maven-scm/issues/718]. 

> CVS Tag Command Not Respecting Single File in ScmFileSet
> --------------------------------------------------------
>
>                 Key: SCM-504
>                 URL: https://issues.apache.org/jira/browse/SCM-504
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-cvs
>    Affects Versions: 1.1
>            Reporter: Paul Lissak
>            Priority: Major
>
> The CVS tag command is not checking the given ScmFileSet for individual 
> files.  This code snippet attempts to apply a tag to just one file:
>     public void applyTag(String tag, File projectFolder, String filename, 
> ScmRepository scmRepository, ScmProvider scmProvider) {
>         ScmFileSet fileSet = new ScmFileSet(projectFolder, new 
> File(filename));
>         scmProvider.tag(scmRepository, fileSet, tag);
>     }
> Lets say the given tag is "TAG_NAME" and the filename is "Example.java", then 
> this is what CVS command is generated:
>     cvs -z3 -f -q tag -F -c TAG_NAME
> The correct CVS command should be:
>     cvs -z3 -f -q tag -F -c TAG_NAME Example.java
> The problem appears to be in the following method:
>     
> org.apache.maven.scm.provider.cvslib.command.tag.AbstractCvsTagCommand.executeTagCommand(ScmProviderRepository,ScmFileSet,String,String)
> The method needs to call getFileList() on the ScmFileSet to see if any 
> individual files are present and then add them to the generated CVS tag 
> command.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to