[ 
https://issues.apache.org/jira/browse/SCM-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17964877#comment-17964877
 ] 

Olivier Lamy commented on SCM-745:
----------------------------------

This project has moved from Jira to GitHub Issues. This issue was migrated to 
[apache/maven-scm#956|https://github.com/apache/maven-scm/issues/956]. 

> Perforce blame result parsing too greedy
> ----------------------------------------
>
>                 Key: SCM-745
>                 URL: https://issues.apache.org/jira/browse/SCM-745
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.8.1, 1.9
>            Reporter: Todd Currie
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.11.1
>
>         Attachments: maven-scm-provider-perforce-blame-auther.patch
>
>
> The regex for the parsing of the author information from the command line 
> results is incorrect.  It is overly greedy and is consuming additional 
> characters depending upon the change comments entered by the author.
> org.apache.maven.scm.provider.perforce.command.blame.PerforceFilelogConsumer
> 39c39
> <     private static final String LINE_PATTERN = "#(\\d+).*on (.*) by (.*)@";
> ---
> >     private static final String LINE_PATTERN = "#(\\d+).*?on (.*?) by 
> > (.*?)@";
> Example of failure:
> Changelist:    624405
> Date:  2013/07/19 14:05
> Client:        ws_advertising
> User:  mccabej
> Description:  
> Fix retry order so that the @Retryable proxy always executes first.
> Resulting Author is "mccabej@ws_advertising (ktext) 'Fix retry order so that 
> the "



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to