[jira] [Commented] (SCM-449) SvnUpdateCommand is updating all the working copy instead of only the fileSet passed in argument

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961574#comment-17961574
 ] 

ASF GitHub Bot commented on SCM-449:
------------------------------------

jira-importer opened a new issue, #662:
URL: https://github.com/apache/maven-scm/issues/662

   **[Jean-Paul 
GUIGUI](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jguigui)** 
opened 
**[SCM-449](https://issues.apache.org/jira/browse/SCM-449?redirect=false)** and 
commented
   
   `scmManager.update()` is updating all the files instead of the files given 
in parameter:
   
   ```
   lScmFile = new ScmFileSet(basedir, myFile);
   lScmResult = scmManager.update(scmRepository, lScmFile);
   ```
   
   Due to the `SvnUpdateCommand.java` which is updating all the working copy, 
not only the `FileSet` given in argument. Here an extract of the line 
`executeUpdateCommand()`:
   
   ```
   Commandline cl = createCommandLine( (SvnScmProviderRepository) repo, 
fileSet.getBasedir(), version );
   ```
   
   Should not we use `fileSet` instead of `fileSet.getBaseDir()` ?
   
   The `SvnCheckInCommand()` is using for instance the `fileSet` only
   
   ```
   Commandline cl = createCommandLine( (SvnScmProviderRepository) repo, 
fileSet, messageFile );
   ```
   
   
   
   ---
   
   **Affects:** 1.1
   




> SvnUpdateCommand is updating all the working copy instead of only the fileSet 
> passed in argument
> ------------------------------------------------------------------------------------------------
>
>                 Key: SCM-449
>                 URL: https://issues.apache.org/jira/browse/SCM-449
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.1
>         Environment: maven 2.0.9
> Java 6
>            Reporter: Jean-Paul GUIGUI
>            Priority: Major
>
> {{scmManager.update()}} is updating all the files instead of the files given 
> in parameter:
> {code}
>  lScmFile = new ScmFileSet(basedir, myFile);
>  lScmResult = scmManager.update(scmRepository, lScmFile);
> {code}
> Due to the {{SvnUpdateCommand.java}} which is updating all the working copy, 
> not only the {{FileSet}} given in argument. Here an extract of the line 
> {{executeUpdateCommand()}}:
> {code}
>         Commandline cl = createCommandLine( (SvnScmProviderRepository) repo, 
> fileSet.getBasedir(), version );
> {code}
> Should not we use {{fileSet}} instead of {{fileSet.getBaseDir()}} ?
> The {{SvnCheckInCommand()}} is using for instance the {{fileSet}} only
> {code}
>         Commandline cl = createCommandLine( (SvnScmProviderRepository) repo, 
> fileSet, messageFile );
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)