[
https://issues.apache.org/jira/browse/SCM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961090#comment-17961090
]
ASF GitHub Bot commented on SCM-338:
------------------------------------
jira-importer commented on issue #556:
URL: https://github.com/apache/maven-scm/issues/556#issuecomment-2964603893
**[Allan
Lang](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=allanlang)**
commented
Suggested patch for above issue. Simply instantiates Settings in order to
avoid NPE.
> NullPointerException when using -DvssDirectory to set ss.exe path
> -----------------------------------------------------------------
>
> Key: SCM-338
> URL: https://issues.apache.org/jira/browse/SCM-338
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-vss
> Affects Versions: 1.0
> Environment: Windows XP, JRE 1.4.2
> Reporter: Allan Lang
> Assignee: Emmanuel Venisse
> Priority: Minor
> Fix For: 1.1
>
> Attachments: SCM-338-[02]-maven-scm-provider-vss.patch,
> SCM-338-maven-scm-provider-vss.patch, vssproviderbug.zip
>
>
> NullPointerException occurs with any SCM operation when there is no
> ~/.scm/vss-settings.xml file, and when the vssDirectory system property is
> set:
> {code}
> Caused by: java.lang.NullPointerException
> at
> org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
> at
> org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
> at
> org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
> at
> org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
> at
> org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
> at
> org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
> ... 21 more
> {code}
> This error is easily replicated using the attached project
> vssproviderbug.zip. Unzip the archive and run
> {code}
> mvn scm:changelog -DvssDirectory=something -e
> {code}
> Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the
> above error in the stack traces. Note that you don't need VSS installed (or
> even to be on Windows) in order to replicate the error - Maven doesn't
> actually get as far as making a call to ss.exe.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
