[
https://issues.apache.org/jira/browse/SCM-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961789#comment-17961789
]
ASF GitHub Bot commented on SCM-494:
------------------------------------
jira-importer commented on issue #706:
URL: https://github.com/apache/maven-scm/issues/706#issuecomment-2964614243
**[Mike
Dillon](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=md5)**
commented
Note: I've defaulted this flag to true in AbstractScmProvider. The only
provider where it is overridden to be false is in AbstractSvnScmProvider. It
should probably be false for some of the other providers as well, but I'm not
sure which ones.
> Let providers indicate whether a commit is required before a tag
> ----------------------------------------------------------------
>
> Key: SCM-494
> URL: https://issues.apache.org/jira/browse/SCM-494
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Improvement
> Components: maven-scm-api
> Reporter: Mike Dillon
> Priority: Minor
> Attachments: requiresCommitBeforeTag.diff
>
>
> As part of looking into creating a patch for MRELEASE-477, I realized that
> SCM providers would need to indicate whether they are able to create a "tag"
> directly from a modified working copy. Subversion can do this, but not all
> providers can. I'm providing a patch that adds a requiresCommitBeforeTag()
> method to ScmProvider, similar to the requiresEditMode() method. It looks
> like there is a request for a general "capabilities" API in SCM-23; this
> would fit into such an API if it existed, but that issue doesn't have a patch
> attached :)
> I haven't provided a test of this since it's only a flag that is not used
> inside maven-scm (I'm planning to provide a patch for maven-release to use it
> there). I could see it being used in scm:tag to allow a generic check for a
> dirty working copy in a local-to-remote tag operation, but it seems like
> these things are better handled by the provider themselves.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
