jira-importer commented on issue #791:
URL: https://github.com/apache/maven-scm/issues/791#issuecomment-2964624337

   **[Ancoron 
Luciferis](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ancoron)**
 commented
   
   OK, I can confirm that the patch indeed fixes this problem but then the 
command sequence still is awful:
   
   ```
   [INFO] [scm:checkout {execution: export-inplace}]
   [INFO] Removing /srv/dev/test/target/upstream-sources
   [INFO] Executing: /bin/sh -c cd /srv/dev/test/target && git clone --branch 
develop http://git.myserver.localdomain/other.git 
/srv/dev/test/target/upstream-sources
   [INFO] Working directory: /srv/dev/test/target
   [INFO] Executing: /bin/sh -c cd /tmp && git ls-remote 
http://git.myserver.localdomain/other.git
   [INFO] Working directory: /tmp
   [INFO] Executing: /bin/sh -c cd /srv/dev/test/target/upstream-sources && git 
pull http://git.myserver.localdomain/other.git develop:develop
   [INFO] Working directory: /srv/dev/test/target/upstream-sources
   [INFO] Executing: /bin/sh -c cd /srv/dev/test/target/upstream-sources && git 
checkout develop
   [INFO] Working directory: /srv/dev/test/target/upstream-sources
   [INFO] Executing: /bin/sh -c cd /srv/dev/test/target/upstream-sources && git 
ls-files
   [INFO] Working directory: /srv/dev/test/target/upstream-sources
   ```
   
   \\
   What I would expect is this:
   
   ```
   [INFO] [scm:checkout {execution: export-inplace}]
   [INFO] Removing /srv/dev/test/target/upstream-sources
   [INFO] Executing: /bin/sh -c cd /srv/dev/test/target && git clone --branch 
develop http://git.myserver.localdomain/other.git 
/srv/dev/test/target/upstream-sources
   [INFO] Working directory: /srv/dev/test/target
   [INFO] Executing: /bin/sh -c cd /tmp && git ls-remote 
http://git.myserver.localdomain/other.git
   [INFO] Working directory: /tmp
   [INFO] Executing: /bin/sh -c cd /srv/dev/test/target/upstream-sources && git 
ls-files
   [INFO] Working directory: /srv/dev/test/target/upstream-sources
   ```
   
   \\
   ...so drop the additional pull and checkout - doesn't make any sense in git, 
really.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to