jira-importer commented on issue #444: URL: https://github.com/apache/maven-indexer/issues/444#issuecomment-2965141051
**[Tamas Cservenak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cstamas)** commented For this issue, I pushed some changes to my github repo, but not yet to ASF SVN. If you'd like, please feel free to comment them. https://github.com/cstamas/maven-indexer/commit/d9fb3f1ef62482a28a1815fe183b0ac23158cc2e Notes: - the work is not completely done yet. GroupedSearch is wide open for OOM for example (non-pageable search type, no way to set "ceiling" yet) - as for "guessing" the topDocs num to return, we could do that "workaround loop" you described in SearchEngine itself: after 1st search, it does know the exact hits number, so if selected "ceiling" (when users does not limit the search) is small, search could be redone with proper number instead. Using MAXINT is no-go, see Lucene's org.apache.lucene.util.PriorityQueue\<T> sources for a "why", it will _always_ OOM. - some methods and constants have "_" prefix. Sorry for that, I just forgot to un-"_" them, was just using compiler help to spot their usage. On final fix, those methods will return to "normal". - these changes will make indexer a bit more OOM prone, so more caution will be needed by integrators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
