[ 
https://issues.apache.org/jira/browse/SCM-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963983#comment-17963983
 ] 

ASF GitHub Bot commented on SCM-1015:
-------------------------------------

jira-importer opened a new issue, #1239:
URL: https://github.com/apache/maven-scm/issues/1239

   **[Konrad 
Windszus](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=kwin)** 
opened 
**[SCM-1015](https://issues.apache.org/jira/browse/SCM-1015?redirect=false)** 
and commented
   
   I was assuming that `ScmProvider` is the SPI while `ScmManager` is the 
(consumer) API. But there are some methods from `ScmProvider` which are not 
called from anywhere else (except for test code) like:
   * `untag`
   * `info`
   * `remoteinfo`
   
   Are those just missing from `ScmManager` (and their implementation 
delegating to the `ScmProvider`'s method in `AbstractScmManager`) or is there 
no clear separation between `ScmProvider` and `ScmManager`?
   
   At the same time some clarification on differences between `ScmRepository` 
and `ScmProviderRepository` would be helpful.
   
   
   ---
   No further details from 
[SCM-1015](https://issues.apache.org/jira/browse/SCM-1015?redirect=false)




> Clarify difference between ScmManager and ScmProvider
> -----------------------------------------------------
>
>                 Key: SCM-1015
>                 URL: https://issues.apache.org/jira/browse/SCM-1015
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Improvement
>          Components: maven-scm-api
>            Reporter: Konrad Windszus
>            Priority: Major
>
> I was assuming that {{ScmProvider}} is the SPI while {{ScmManager}} is the 
> (consumer) API. But there are some methods from {{ScmProvider}} which are not 
> called from anywhere else (except for test code) like:
> * {{untag}}
> * {{info}}
> * {{remoteinfo}}
> Are those just missing from {{ScmManager}} (and their implementation 
> delegating to the {{ScmProvider}}'s method in {{AbstractScmManager}}) or is 
> there no clear separation between {{ScmProvider}} and {{ScmManager}}?
> At the same time some clarification on differences between {{ScmRepository}} 
> and {{ScmProviderRepository}} would be helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to