[
https://issues.apache.org/jira/browse/SCM-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963741#comment-17963741
]
ASF GitHub Bot commented on SCM-939:
------------------------------------
jira-importer commented on issue #1165:
URL: https://github.com/apache/maven-scm/issues/1165#issuecomment-2964649557
**[Elliotte Rusty
Harold](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elharo)**
commented
This is tricky because Maven incorrectly treats an assumption violation as
an error. The assumption violation gets wrapped in a MojoFailureException.
[ERROR] Errors:
[ERROR] CvsExeChangeLogCommandTest>CvsChangeLogCommandTest.setUp:48 »
AssumptionViolated
[ERROR] CvsExeChangeLogCommandTest>CvsChangeLogCommandTest.setUp:48 »
AssumptionViolated
[ERROR] CvsExeChangeLogCommandTest>CvsChangeLogCommandTest.setUp:48 »
AssumptionViolated
[ERROR] CvsExeCheckoutCommandTest>CvsCheckoutCommandTest.setUp:50 »
AssumptionViolated
[ERROR] CvsExeCheckoutCommandTest>CvsCheckoutCommandTest.setUp:50 »
AssumptionViolated
[ERROR] CvsExeUpdateCommandTest>CvsUpdateCommandTest.setUp:59 »
AssumptionViolated got...
[INFO]
[ERROR] Tests run: 7, Failures: 0, Errors: 6, Skipped: 0
[INFO]
> Assume SCM is present
> ---------------------
>
> Key: SCM-939
> URL: https://issues.apache.org/jira/browse/SCM-939
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 2.1.0
>
>
> We have a lot of tests that do something like this:
>
> if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
> {
> ScmTestCase.printSystemCmdUnavail( SvnScmTestUtils.SVN_COMMAND_LINE,
> getName() );
> return;
> }
>
> We should instead use org.*junit*.*Assume* here so these are marked as
> skipped rather than passed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
