[ 
https://issues.apache.org/jira/browse/SCM-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961883#comment-17961883
 ] 

ASF GitHub Bot commented on SCM-518:
------------------------------------

jira-importer commented on issue #731:
URL: https://github.com/apache/maven-scm/issues/731#issuecomment-2964615524

   **[Michael 
Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o)**
 commented
   
   Fixed with 
[368968b814ec983f2e504be0907ad2187148b594](https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=368968b814ec983f2e504be0907ad2187148b594).
   




> wrong model in vss-settings.mdo works only with a bug in Modello 1.0-alpha-21 
> but not with Modello 1.0+
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SCM-518
>                 URL: https://issues.apache.org/jira/browse/SCM-518
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-vss
>    Affects Versions: 1.2
>            Reporter: Hervé Boutemy
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.11.1
>
>
> after [documentation|http://maven.apache.org/scm/vss.html], vss-settings.xml 
> file content is 
> {code:xml}<vss-settings>
>   <Settings>
>     <vssDirectory>ss_exe_directory</vssDirectory>
>   </Settings>
> </vss-settings>
> {code}
> but actual vss-settings.mdo does not define "Settings" field.
> Reading such a file works only because of a bug in Modello parsing: 
> MODELLO-152, which has been fixed in Modello 1.0.
> There are 2 options for us: either change the documentation (and tell the 
> users) to support following model (which was the initial intend IMHO):
> {code:xml}<vss-settings>
>   <vssDirectory>ss_exe_directory</vssDirectory>
> </vss-settings>
> {code}
> or tweak the model and update the code to create an intermediate class for 
> this Settings element (only useful to avoid changing the XML format)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to