[ 
https://issues.apache.org/jira/browse/SCM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962399#comment-17962399
 ] 

ASF GitHub Bot commented on SCM-646:
------------------------------------

jira-importer opened a new issue, #856:
URL: https://github.com/apache/maven-scm/issues/856

   **[Petr 
Kozelka](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pkozelka)**
 opened 
**[SCM-646](https://issues.apache.org/jira/browse/SCM-646?redirect=false)** and 
commented
   
   Current implementation of GitChangeLogConsumer fills revision on each 
ChangeFile but not on its containing ChangeSet - where it IMHO naturally 
belongs.
   
   I fixed this on GitHub and submitted a pull request here:
   https://github.com/apache/maven-scm/pull/1
   
   I guess that Apache does not process Github pull-requests yet so I am 
attaching the patch also here.
   In this patch, also unittest is extended to cover checking changeset 
revision as well.
   
   
   ---
   
   **Affects:** 1.5
   
   **Attachments:**
   - 
[SCM-git-changeset-revision.patch](https://issues.apache.org/jira/secure/attachment/12718670/SCM-git-changeset-revision.patch)
 (_3.56 kB_)
   




> git parser should fill changeset revision
> -----------------------------------------
>
>                 Key: SCM-646
>                 URL: https://issues.apache.org/jira/browse/SCM-646
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.5
>            Reporter: Petr Kozelka
>            Assignee: Olivier Lamy
>            Priority: Major
>             Fix For: 1.6
>
>         Attachments: SCM-git-changeset-revision.patch
>
>
> Current implementation of GitChangeLogConsumer fills revision on each 
> ChangeFile but not on its containing ChangeSet - where it IMHO naturally 
> belongs.
> I fixed this on GitHub and submitted a pull request here:
> https://github.com/apache/maven-scm/pull/1
> I guess that Apache does not process Github pull-requests yet so I am 
> attaching the patch also here.
> In this patch, also unittest is extended to cover checking changeset revision 
> as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to