jira-importer commented on issue #979:
URL: https://github.com/apache/maven-scm/issues/979#issuecomment-2964637096

   **[Gary L 
Peskin](https://issues.apache.org/jira/secure/[email protected])**
 commented
   
   I think you'll find that most of the patch is just enhancing the testing 
components.  I agree that the URI does give an easy way to calculate the 
relative path.  However, using the URI approach failed in my use case due to 
the special characters.  I made sure that the code still passed all of the 
tests on both Windows 7 and Amazon Linux.  It would be great if you could find 
places where the new code fails and then I can add those to the test and 
enhance the code to take that into account.  There is now a Path.relativize() 
method that calculates the relative path but the Path class didn't come in 
until Java SE 1.7 so I didn't use it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to