[jira] [Commented] (SCM-940) ScmTestCase.getModule should be abstract

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/SCM-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963735#comment-17963735
 ] 

ASF GitHub Bot commented on SCM-940:
------------------------------------

jira-importer opened a new issue, #1164:
URL: https://github.com/apache/maven-scm/issues/1164

   **[Elliotte Rusty 
Harold](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elharo)** 
opened 
**[SCM-940](https://issues.apache.org/jira/browse/SCM-940?redirect=false)** and 
commented
   
   This is the current code. There's no reason to make this a runtime problem 
instead of a compile time problem.
   
    
   
   protected String getModule()
   {
   fail( "getModule() must be overridden." );
   
   return null;
   }
   
   
   ---
   
   **Remote Links:**
   - [GitHub Pull Request #103
   ](https://github.com/apache/maven-scm/pull/103)
   




> ScmTestCase.getModule should be abstract
> ----------------------------------------
>
>                 Key: SCM-940
>                 URL: https://issues.apache.org/jira/browse/SCM-940
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Improvement
>            Reporter: Elliotte Rusty Harold
>            Assignee: Elliotte Rusty Harold
>            Priority: Minor
>
> This is the current code. There's no reason to make this a runtime problem 
> instead of a compile time problem.
>  
> protected String getModule()
>  {
>  fail( "getModule() must be overridden." );
> return null;
>  }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)