slawekjaranowski commented on code in PR #555:
URL: https://github.com/apache/maven-war-plugin/pull/555#discussion_r2395856792
##########
src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java:
##########
@@ -230,6 +230,26 @@ public abstract class AbstractWarMojo extends AbstractMojo
{
@Parameter
private String dependentWarExcludes =
StringUtils.join(Overlay.DEFAULT_EXCLUDES, ",");
+ /**
+ * The comma separated list of tokens to exclude from the WAR before
packaging. This option may be used to implement
+ * the skinny WAR use case. Note that you can use the Java Regular
Expressions engine to include and exclude
+ * specific pattern using the expression %regex[]. Hint: read the about
(?!Pattern).
+ *
+ * @since 2.1-alpha-2
+ */
+ @Parameter(property = "maven.war.packagingExcludes")
+ private String packagingExcludes;
+
+ /**
+ * The comma separated list of tokens to include in the WAR before
packaging. By default everything is included.
+ * This option may be used to implement the skinny WAR use case. Note that
you can use the Java Regular Expressions
+ * engine to include and exclude specific pattern using the expression
%regex[].
+ *
+ * @since 2.1-beta-1
+ */
+ @Parameter
Review Comment:
please also add a `property` similar to `packagingExcludes`
we can add `default="**"`
##########
src/main/java/org/apache/maven/plugins/war/AbstractWarMojo.java:
##########
@@ -230,6 +230,26 @@ public abstract class AbstractWarMojo extends AbstractMojo
{
@Parameter
private String dependentWarExcludes =
StringUtils.join(Overlay.DEFAULT_EXCLUDES, ",");
+ /**
+ * The comma separated list of tokens to exclude from the WAR before
packaging. This option may be used to implement
+ * the skinny WAR use case. Note that you can use the Java Regular
Expressions engine to include and exclude
+ * specific pattern using the expression %regex[]. Hint: read the about
(?!Pattern).
+ *
+ * @since 2.1-alpha-2
+ */
+ @Parameter(property = "maven.war.packagingExcludes")
+ private String packagingExcludes;
+
+ /**
+ * The comma separated list of tokens to include in the WAR before
packaging. By default everything is included.
+ * This option may be used to implement the skinny WAR use case. Note that
you can use the Java Regular Expressions
+ * engine to include and exclude specific pattern using the expression
%regex[].
+ *
+ * @since 2.1-beta-1
+ */
+ @Parameter
+ private String packagingIncludes;
Review Comment:
`List<String>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
