desruisseaux commented on PR #959: URL: https://github.com/apache/maven-compiler-plugin/pull/959#issuecomment-3393527136
I added a commit for enabling multi-release in modular projects only if the `-Dmaven.compiler.preview=true` option is given to the `mvn` command. If this option is not provided, the compilation fails with the following error message: ``` [ERROR] Failed to execute goal (…snip long coordinate…) on project multirelease-with-modules: Cannot compile org.apache.maven.plugins:multirelease-with-modules:jar:1.0-SNAPSHOT main classes. [ERROR] The first error is: Multi-release in a modular project is a preview feature. For enabling this feature, add the -Dmaven.compiler.preview=true option to the mvn command. ``` If a preview flag is added in Maven core, we could replace the `maven.compiler.preview` property by that flag in a future version. This approach would bring the bug fixes and improvements of this pull request when the directory layout is classic (i.e., as Maven 3) without committing ourselves to the directory structure described in the "Directory layout choice" section in the summary of this pull request. That layout would be disabled by default. @gnodet, @cstamas or @slawekjaranowski, would it be an acceptable way to go forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
