fridrich commented on PR #1274: URL: https://github.com/apache/maven-javadoc-plugin/pull/1274#issuecomment-3414934667
I mean, I run the ITs with openjdk 8 11 and 17 and they passed. My only concern is that the mismatch is in what one gets from plexus-utils as path in string ant its encoding and how one reads the line. The thing is that - as I understand it now - it boils down to the filesystem encoding itself for java 8. Because the com.sun.tools.javac.main.CommandLine.loadCmdFile in java 8 does not specify any encoding at all and when I go down the code, it looks like encoding is always assumed. For java9-12 (verified in 11), the function calls `Reader r = Files.newBufferedReader(Paths.get(name))` which assumes UTF-8.INSTANCE. That was changed to `Reader r = Files.newBufferedReader(Paths.get(name), Charset.defaultCharset())` for 13+. Now the `Charset.defaultCharset()`, can it diverge from the filesystem encoding? Maybe and there it would be actually the problem that we have. Were the `Charset.defaultCharset()` for file content encoding, then that might be a possible mismatch. Like on Linux, you can have java 8 running on a filesystem that is UTF-8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
