elharo commented on code in PR #1433:
URL: https://github.com/apache/maven-site/pull/1433#discussion_r2442432485


##########
content/markdown/whatsnewinmaven4.md:
##########
@@ -117,6 +117,26 @@ Model version 4.1.0 contains a new `<subprojects>` element 
analogous to the now
 **Note**: Use the terms `multi-project setup` and `single-project setup` to 
differentiate between a Maven project with
 or without subprojects.
 
+### New artifact types
+
+Maven 4 introduces new types of artifacts.
+The types listed below can be used in `<dependency>` declarations of JAR files.
+The `jar` type existed in Maven 3 and is still the default in Maven 4.
+The other types are new:
+
+* `jar`: for a JAR file that can be placed either on the class path or on the 
module path.
+* `classpath-jar`: for a JAR file to unconditionally place on the class path.

Review Comment:
   to unconditionally place --> that is unconditionally placed on the classpath



##########
content/markdown/whatsnewinmaven4.md:
##########
@@ -117,6 +117,26 @@ Model version 4.1.0 contains a new `<subprojects>` element 
analogous to the now
 **Note**: Use the terms `multi-project setup` and `single-project setup` to 
differentiate between a Maven project with
 or without subprojects.
 
+### New artifact types
+
+Maven 4 introduces new types of artifacts.
+The types listed below can be used in `<dependency>` declarations of JAR files.
+The `jar` type existed in Maven 3 and is still the default in Maven 4.
+The other types are new:
+
+* `jar`: for a JAR file that can be placed either on the class path or on the 
module path.
+* `classpath-jar`: for a JAR file to unconditionally place on the class path.
+* `modular-jar`: for a JAR file to unconditionally place on the module path.

Review Comment:
   to unconditionally place --> that is unconditionally placed on the module 
path
   
   Also, why is this modular-jar instead of modulepath-jar?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to