kwin commented on code in PR #543:
URL:
https://github.com/apache/maven-apache-parent/pull/543#discussion_r2444731939
##########
pom.xml:
##########
@@ -497,6 +494,17 @@ under the License.
</build>
</profile>
<!-- END SNIPPET: release-profile -->
+ <profile>
+ <id>jdk8</id>
+ <activation>
+ <jdk>[,9)</jdk>
+ </activation>
+ <properties>
+ <maven.compiler.source>${maven.compiler.target}</maven.compiler.source>
Review Comment:
@desruisseaux
> The --release option is not supported using JDK 8. However, since Compiler
plugin version 3.13.0 you can use the release property also on JDK 8. The
plugin will convert it to source and target automatically.
(from
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#Usage_on_JDK_8)
##########
pom.xml:
##########
@@ -497,6 +494,17 @@ under the License.
</build>
</profile>
<!-- END SNIPPET: release-profile -->
+ <profile>
+ <id>jdk8</id>
+ <activation>
+ <jdk>[,9)</jdk>
+ </activation>
+ <properties>
+ <maven.compiler.source>${maven.compiler.target}</maven.compiler.source>
Review Comment:
@desruisseaux
> The --release option is not supported using JDK 8. However, since Compiler
plugin version 3.13.0 you can use the release property also on JDK 8. The
plugin will convert it to source and target automatically.
(from
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#Usage_on_JDK_8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
