slawekjaranowski commented on code in PR #487:
URL: https://github.com/apache/maven-jar-plugin/pull/487#discussion_r2450687098


##########
src/it/project-004/pom.xml:
##########
@@ -49,7 +49,7 @@
       </plugin>
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.3</version>
+        <version>3.5.4</version>

Review Comment:
   every properties defined in project are here available
   
   this doc is related 
https://maven.apache.org/plugins/maven-invoker-plugin/examples/filtering.html
   
   and we have defined 
https://github.com/apache/maven-apache-parent/blob/53984b002daf8826db93080a298a931d3bdc0465/pom.xml#L137
   
   ```
       <version.maven-surefire>${surefire.version}</version.maven-surefire>
   ```
   
   so we can use in IT `@version.maven-surefire@`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to