desruisseaux commented on code in PR #987:
URL:
https://github.com/apache/maven-compiler-plugin/pull/987#discussion_r2468472414
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1451,13 +1458,37 @@ private boolean isVersionEqualOrNewer(String
sourceVersion) {
return supportedVersion.compareTo(requested) >= 0;
}
+ /**
+ * Returns whether the given collection is null or empty, ignoring spaces.
+ * This is a convenience for a frequent check, and also for clarity.
+ */
+ private static boolean isNullOrEmpty(String c) {
Review Comment:
For the `groupId` renaming question, answer
[here](https://github.com/apache/maven-compiler-plugin/pull/987#discussion_r2468334927).
For the "empty versus blank", I was taking "empty" is a lossy sense more
similar to `Optional.isEmpty()`, for meaning "value is not specified", and I
was hopping for a consistent name between the versions taking different kinds
of arguments. In an attempt to clarify, I renamed all `isNullOrEmpty` by
`isAbsent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
