desruisseaux commented on PR #988: URL: https://github.com/apache/maven-compiler-plugin/pull/988#issuecomment-3479532210
The methods renaming are fine for me, but I'm surprised by the removal of the `public` keywords. I would agree if this was the JAR that we publish (for better encapsulation), but those tests are not published and those methods need to be accessed by JUnit. I know that since version 5, JUnit can invoke non-public methods. But if we modularize Maven (something that I hope to prototype after completion of full JPMS support in all required plugins), it will require that we add `--add-opens` options for all packages containing test classes. It should be easy with `module-info-patch.maven`, but this is nevertheless an unnecessary additional complexity. Keeping the methods public also has the advantage of making clear what we intend to be accessed by JUnit, and what we intend to keep as internal helper methods for the tests (e.g. fixtures). Should we rerun the recipe, but without the removal of `public` keywords? Same comment applies to https://github.com/apache/maven-jar-plugin/pull/489, https://github.com/apache/maven-clean-plugin/pull/279 and https://github.com/apache/maven-resources-plugin/pull/427. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
