chihyu0917 opened a new pull request, #1017:
URL: https://github.com/apache/maven-doxia/pull/1017
### Motivation
`MarkdownParserTest#testHtmlContent` was brittle around HTML tables.
Inside `<table><tbody>…</tbody></table>`, the event stream intermittently
included extra `"text"` whitespace nodes and `"unknown"` nodes (tbody boundary
markers), which caused order-sensitive assertions to fail (e.g., expecting text
but seeing `tableRow` / `tableHeaderCell_`). This is environmental/renderer
dependent and shows up under different JDKs/runners and with NonDex.
### Design / Implementation
- Replace the large positional `assertSinkEquals(...)` block for this test
with a compact normalization loop:
- Iterate the emitted events.
- Track when we are inside `tableRows` … `tableRows_`.
- While inside that region, skip intermittent "text" and "unknown" events.
- Compare the remaining sequence with a concise exp list.
Scope is only `htmlContent`; no production code touched, no new imports or
dependencies.
### Reproduce the error
- Error message:
`org.apache.maven.doxia.module.markdown.MarkdownParserTest.htmlContent -- Time
elapsed: 0.869 s <<< FAILURE!
org.opentest4j.AssertionFailedError`
- Reproduce: `mvn -pl doxia-modules/doxia-module-markdown
edu.illinois:nondex-maven-plugin:2.1.7:nondex
-Dtest=org.apache.maven.doxia.module.markdown.MarkdownParserTest#htmlContent`
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
