kwin commented on code in PR #1466:
URL: https://github.com/apache/maven-site/pull/1466#discussion_r2542977119
##########
content/markdown/pom.md:
##########
@@ -1802,10 +1802,11 @@ and supporting files generated throughout the build
process.
#### Repository
-Whereas the repositories element specifies in the POM the location and manner
in which Maven may
-download remote artifacts for use by the current project,
distributionManagement specifies where
-(and how) this project will get to a remote repository when it is deployed.
-The repository elements will be used for snapshot distribution if the
snapshotRepository is not defined.
+Whereas the `<project><repositories><repository>` elements specify in the POM
the location and manner in which Maven may
Review Comment:
```suggestion
Whereas the `<project><repositories><repository>` elements specify the
location and manner in which Maven may
```
##########
content/markdown/pom.md:
##########
@@ -1840,8 +1841,11 @@ The repository elements will be used for snapshot
distribution if the snapshotRe
the address.
* `<url>`:
- This is the core of the repository element. It specifies both the location
and the transport protocol
+ This is the core of the distributionManagement repository element. It
specifies both the location and the transport protocol
used to transfer a built artifact (and POM file, and checksum data) to the
repository.
+ Notice that the url to download from the repository is often different:
publishing (using distributionManagement repository url) can be done with scp
protocol or a REST API,
+ while download is often basic https (GET). Distribution management
repository url and (download) repository url are the same only
+ when you can do for example HTTPS PUT for upload and HTTPS GET for download
from the same web server.
Review Comment:
```suggestion
when you can do for example HTTP PUT for upload and HTTP GET for download
from the same web server.
```
##########
content/markdown/pom.md:
##########
@@ -1840,8 +1841,11 @@ The repository elements will be used for snapshot
distribution if the snapshotRe
the address.
* `<url>`:
- This is the core of the repository element. It specifies both the location
and the transport protocol
+ This is the core of the distributionManagement repository element. It
specifies both the location and the transport protocol
used to transfer a built artifact (and POM file, and checksum data) to the
repository.
+ Notice that the url to download from the repository is often different:
publishing (using distributionManagement repository url) can be done with scp
protocol or a REST API,
+ while download is often basic https (GET). Distribution management
repository url and (download) repository url are the same only
Review Comment:
```suggestion
while download is in most cases HTTP GET. Distribution management
repository url and (download) repository url are the same only
```
##########
content/markdown/pom.md:
##########
@@ -1840,8 +1841,11 @@ The repository elements will be used for snapshot
distribution if the snapshotRe
the address.
* `<url>`:
- This is the core of the repository element. It specifies both the location
and the transport protocol
+ This is the core of the distributionManagement repository element. It
specifies both the location and the transport protocol
used to transfer a built artifact (and POM file, and checksum data) to the
repository.
+ Notice that the url to download from the repository is often different:
publishing (using distributionManagement repository url) can be done with scp
protocol or a REST API,
Review Comment:
```suggestion
Notice that the url to download from the repository is often different:
publishing (using distributionManagement repository url) can be done by a
variety of protocols (with SCP, HTTP POST, FTP, ...)
```
##########
content/markdown/pom.md:
##########
@@ -1802,10 +1802,11 @@ and supporting files generated throughout the build
process.
#### Repository
-Whereas the repositories element specifies in the POM the location and manner
in which Maven may
-download remote artifacts for use by the current project,
distributionManagement specifies where
-(and how) this project will get to a remote repository when it is deployed.
-The repository elements will be used for snapshot distribution if the
snapshotRepository is not defined.
+Whereas the `<project><repositories><repository>` elements specify in the POM
the location and manner in which Maven may
+download remote artifacts for use by the current project,
`<project><distributionManagement><repository>` specifies where
+(and how) this project will get to a remote repository when it is deployed
(aka. published to remote).
Review Comment:
```suggestion
(and how) the artifacts generated through this project will get uploaded to
a remote repository when it is deployed (aka. published to remote).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
