Bukama commented on code in PR #11495:
URL: https://github.com/apache/maven/pull/11495#discussion_r2570024314
##########
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java:
##########
@@ -308,13 +326,37 @@ public static org.apache.maven.model.RepositoryPolicy
fromSettingsRepositoryPoli
return modelRepositoryPolicy;
}
+ /**
+ * @deprecated use a service metod {@link
#buildArtifactRepositoryFromRepo(org.apache.maven.settings.Repository) instead
+ */
+ @Deprecated
public static ArtifactRepository
buildArtifactRepository(org.apache.maven.settings.Repository repo)
throws InvalidRepositoryException {
- return buildArtifactRepository(fromSettingsRepository(repo));
+ return instance.buildArtifactRepositoryFromRepo(repo);
}
+ /**
+ * @since 3.9.12
+ */
+ public ArtifactRepository
buildArtifactRepositoryFromRepo(org.apache.maven.settings.Repository repo)
+ throws InvalidRepositoryException {
+ return buildArtifactRepositoryFromRepo(fromSettingsRepository(repo));
+ }
+
+ /**
+ * @deprecated use a service metod {@link
#buildArtifactRepositoryFromRepo(Repository)} instead
Review Comment:
method
##########
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java:
##########
@@ -816,4 +858,43 @@ else if (layout.equals(repoLayout)) {
return result;
}
+
+ /**
+ * In the future, the legacy system might encounter repository types for
which no layout components exists because
+ * the actual communication with the repository happens via a repository
connector. As a minimum, the legacy system
+ * needs to retain the id of this layout so that the content type of the
remote repository can still be accurately
+ * described.
+ */
+ static class UnknownRepositoryLayout implements ArtifactRepositoryLayout {
+
+ private final String id;
+
+ private final ArtifactRepositoryLayout fallback;
+
+ UnknownRepositoryLayout(String id, ArtifactRepositoryLayout fallback) {
+ this.id = id;
+ this.fallback = fallback;
+ }
+
Review Comment:
Javadoc missing for methods
##########
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java:
##########
@@ -308,13 +326,37 @@ public static org.apache.maven.model.RepositoryPolicy
fromSettingsRepositoryPoli
return modelRepositoryPolicy;
}
+ /**
+ * @deprecated use a service metod {@link
#buildArtifactRepositoryFromRepo(org.apache.maven.settings.Repository) instead
Review Comment:
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
