elharo commented on code in PR #1440:
URL: https://github.com/apache/maven-release/pull/1440#discussion_r2572333230
##########
maven-release-plugin/src/it/projects/prepare/semver-major-release-policy/pom.xml:
##########
@@ -0,0 +1,52 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
why the tildes? Doubt it really matters, but I don't think I've seen this
before.
##########
maven-release-policies/maven-release-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVerMajorReleaseVersionPolicy.java:
##########
@@ -33,7 +33,7 @@
*/
@Singleton
@Named("SemVerMajorRelease")
-public class SemVerMajorReleaseVersionPolicy extends
AbstractSemVerVersionPolicy {
+class SemVerMajorReleaseVersionPolicy extends AbstractSemVerVersionPolicy {
Review Comment:
This does seem like it might be an API breaking change since the class was
public before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
