slawekjaranowski commented on code in PR #1441:
URL: https://github.com/apache/maven-release/pull/1441#discussion_r2572610077
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -113,7 +113,7 @@ public void executeGoals(
targetGoals.add(additionalArguments);
}
- req.setGoals(targetGoals);
+ req.addArgs(targetGoals);
Review Comment:
It is correctly deprecated ... but when we use new method we need new
parameters where user set each command line argument separately
Parsing, escaping arguments are allwaye error prone, so we should required
from users to provided it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
