cowwoc commented on code in PR #395:
URL:
https://github.com/apache/maven-build-cache-extension/pull/395#discussion_r2578139704
##########
src/main/java/org/apache/maven/buildcache/CacheResult.java:
##########
@@ -31,49 +34,91 @@ public class CacheResult {
private final RestoreStatus status;
private final Build build;
private final CacheContext context;
+ private final Map<String, MojoExecutionEvent> validationTimeEvents;
- private CacheResult(RestoreStatus status, Build build, CacheContext
context) {
+ private CacheResult(
+ RestoreStatus status,
+ Build build,
+ CacheContext context,
+ Map<String, MojoExecutionEvent> validationTimeEvents) {
Review Comment:
I opted to make this method package-private instead of returning a copy. Is
that okay? See
https://github.com/apache/maven-build-cache-extension/pull/395/commits/6cf3a361c988f9acdf97b291f93e8af9a6a0551f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
