elharo commented on code in PR #1479: URL: https://github.com/apache/maven-site/pull/1479#discussion_r2596362852
########## content/markdown/guides/introduction/introduction-to-profiles.md: ########## @@ -43,17 +43,19 @@ To address these circumstances, Maven supports build profiles. Profiles are spec ## Profile Inheritance -The profiles are not inherited as other POM elements by child POMs. Instead they are resolved very early by the [Maven Model Builder](/ref/current/maven-model-builder/) and only the effects of active profiles are inherited (e.g. the plugins defined in the profile). That also leads to the fact that implicit profile activation only has an effect on the surrounding profile container but never on any other profile (even if it has the same id). +The profiles are not inherited as other POM elements by child POMs. Instead, they are resolved very early by the [Maven Model Builder](/ref/current/maven-model-builder/) and only the effects of active profiles are inherited (e.g. the plugins defined in the profile). Implicit profile activation only has an effect on the surrounding profile container but never on any other profile (even if it has the same id). Review Comment: I'm tempted to delete "as other POM elements". Its reference is ambiguous ########## content/markdown/guides/introduction/introduction-to-profiles.md: ########## @@ -101,11 +103,14 @@ This profile will automatically be active for all builds unless another profile #### Implicit profile activation -Profiles can be automatically triggered based on the detected state of the build environment. These triggers are specified via an `<activation>` section in the profile itself. Currently, this detection is limited to JDK version matching, operating system matching or the presence/the value of a system property. The implicit profile activation always only refers to the container profile (and not to profiles in other modules with the same id). Here are some examples. +Profiles can be automatically triggered based on the detected state of the build environment. +These triggers are specified via an `<activation>` section in the profile itself. +The implicit profile activation always only refers to the container profile (and not to profiles in other modules with the same id). Review Comment: delete "always" ########## content/markdown/guides/introduction/introduction-to-profiles.md: ########## @@ -101,11 +103,14 @@ This profile will automatically be active for all builds unless another profile #### Implicit profile activation -Profiles can be automatically triggered based on the detected state of the build environment. These triggers are specified via an `<activation>` section in the profile itself. Currently, this detection is limited to JDK version matching, operating system matching or the presence/the value of a system property. The implicit profile activation always only refers to the container profile (and not to profiles in other modules with the same id). Here are some examples. +Profiles can be automatically triggered based on the detected state of the build environment. +These triggers are specified via an `<activation>` section in the profile itself. Review Comment: delete "itself" ########## content/markdown/guides/introduction/introduction-to-profiles.md: ########## @@ -101,11 +103,14 @@ This profile will automatically be active for all builds unless another profile #### Implicit profile activation -Profiles can be automatically triggered based on the detected state of the build environment. These triggers are specified via an `<activation>` section in the profile itself. Currently, this detection is limited to JDK version matching, operating system matching or the presence/the value of a system property. The implicit profile activation always only refers to the container profile (and not to profiles in other modules with the same id). Here are some examples. +Profiles can be automatically triggered based on the detected state of the build environment. Review Comment: delete "detected" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
