cstamas commented on code in PR #11501:
URL: https://github.com/apache/maven/pull/11501#discussion_r2598331075
##########
maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
##########
@@ -37,19 +36,29 @@
import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.logging.Logger;
+import org.eclipse.aether.internal.impl.TrackingFileManager;
/**
* DefaultUpdateCheckManager
*/
-@Component(role = UpdateCheckManager.class)
+@Named
+@Singleton
public class DefaultUpdateCheckManager extends AbstractLogEnabled implements
UpdateCheckManager {
+ private final TrackingFileManager trackingFileManager;
private static final String ERROR_KEY_SUFFIX = ".error";
- public DefaultUpdateCheckManager() {}
+ @Inject
Review Comment:
Just make/leave this plain old plx component with field injection instead,
and as said above, it will leave things less intrusive re UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
