Giovds commented on issue #351:
URL:
https://github.com/apache/maven-help-plugin/issues/351#issuecomment-3646271751
I took a quick look into this. This will require a change in `maven-core`.
More specifically, the reason this happens (in Maven 3) is due to the
evaluator used in the help-plugin. The `PluginParameterExpressionEvaluator`,
which basically predefines a couple of checks, including
`startsWith("plugin")`, before reaching the 'I don't know, let me look into
user and system properties' step. We will see the same behaviour with any other
predefined check such as `project.*, mojo.*, settings.*`.
Quickly looking into `PluginParameterExpressionEvaluatorV4` (Maven 4
equivalent) this implementation will change a little bit.
I've written a test for both in maven-core. With the V4 evaluator this
specific case will work, though I see the same behaviour for the kept prefixes.
Besides that, the help-plugin is not yet Maven 4 compatible.
The question is: Should certain prefixes take precedence over properties?
I see a couple of options, that could be considered;
1. Wait for Maven 4 support
2. Change the implementation of Maven 3 plugin evaluator (I don't know the
impact of this)
3. Not support this as some properties are 'reserved keywords'
Perhaps, in all cases this behaviour should be documented somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
