Copilot commented on code in PR #1564:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1564#discussion_r2635169576
##########
src/it/projects/mdep-839-list/verify.groovy:
##########
@@ -19,10 +19,10 @@
File file = new File( basedir, "classpath.txt" )
assert file.exists() : "output file $file does not exist"
-
String output = file.getText( "UTF-8" )
assert output.startsWith( 'The following files have been resolved:')
// no escape codes
assert !output.contains( '\u001B' )
+assert output.contains( 'compile -- module' )
Review Comment:
This test expects 'compile -- module' (with double dash), but the code in
ResolveDependenciesMojo.java line 238 was changed to use a single dash ' -
module'. This test will fail. Update this assertion to use 'compile - module'
to match the implementation change, or revert the code change if the
double-dash format should be preserved.
```suggestion
assert output.contains( 'compile - module' )
```
##########
pom.xml:
##########
@@ -366,7 +366,12 @@ under the License.
<version>${mockito.version}</version>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.fusesource.jansi</groupId>
+ <artifactId>jansi</artifactId>
+ <version>2.4.2</version>
+ <scope>test</scope>
+ </dependency>
<dependency>
Review Comment:
The jansi dependency was added with test scope and marked as ignored in the
dependency analyzer, but it is not used anywhere in the codebase (neither in
main code nor test code). Either this dependency should be utilized for
stripping ANSI codes, or it should be removed if it's not needed. Note that
jansi is typically a transitive dependency through maven-shared-utils and may
not need to be explicitly declared unless you're using it directly.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
