ascopes commented on code in PR #1046:
URL:
https://github.com/apache/maven-plugin-tools/pull/1046#discussion_r2642804353
##########
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##########
@@ -573,4 +579,17 @@ protected void validate(MojoDescriptor mojoDescriptor)
throws InvalidParameterEx
}
}
}
+
+ private boolean isExcludedDirectory(Collection<File> excludedDirectories,
File sourceFile) {
+ for (File excludedScanDirectory : excludedDirectories) {
+ File candidateFile = sourceFile;
+ while (candidateFile != null) {
+ if (excludedScanDirectory.equals(candidateFile)) {
+ return true;
+ }
+ candidateFile = candidateFile.getParentFile();
+ }
+ }
+ return false;
+ }
Review Comment:
Currently two separate JARs considered making it common but the overhead of
doing so seems to outweigh the benefits given the fact this is strategic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
