Copilot commented on code in PR #206:
URL:
https://github.com/apache/maven-changelog-plugin/pull/206#discussion_r2647197490
##########
src/test/java/org/apache/maven/plugins/changelog/stubs/ScmManagerStub.java:
##########
@@ -196,6 +203,12 @@ public CheckInScmResult checkIn(ScmRepository repository,
ScmFileSet fileSet, St
return this.getProviderByRepository(repository).checkIn(repository,
fileSet, message);
}
+ @Override
+ public CheckInScmResult checkIn(ScmRepository repository, ScmFileSet
fileSet, CommandParameters commandParameters)
+ throws ScmException {
+ return this.getProviderByRepository(repository).checkIn(repository,
fileSet, commandParameters);
+ }
Review Comment:
This new method is missing JavaDoc documentation. All other methods in this
file follow the pattern of having a JavaDoc comment with {@inheritDoc}. Add the
following comment before the @Override annotation to maintain consistency with
the codebase:
/**
* {@inheritDoc}
*/
##########
src/test/java/org/apache/maven/plugins/changelog/stubs/ScmManagerStub.java:
##########
@@ -75,6 +77,11 @@ public ScmRepository makeProviderScmRepository(String
string, File file) {
return null;
}
+ @Override
+ public Optional<ScmRepository> makeProviderScmRepository(File file) {
+ return Optional.empty();
+ }
Review Comment:
This new method is missing JavaDoc documentation. All other methods in this
file follow the pattern of having a JavaDoc comment with {@inheritDoc}. Add the
following comment before the @Override annotation to maintain consistency with
the codebase:
/**
* {@inheritDoc}
*/
##########
src/test/java/org/apache/maven/plugins/changelog/stubs/ScmProviderStub.java:
##########
@@ -214,6 +214,11 @@ public CheckInScmResult checkIn(ScmRepository
scmRepository, ScmFileSet scmFileS
return null;
}
+ @Override
+ public CheckInScmResult checkIn(ScmRepository scmRepository, ScmFileSet
scmFileSet, CommandParameters parameters) {
+ return null;
+ }
Review Comment:
This new method is missing JavaDoc documentation. All other methods in this
file follow the pattern of having a JavaDoc comment with {@inheritDoc}. Add the
following comment before the @Override annotation to maintain consistency with
the codebase:
/**
* {@inheritDoc}
*/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
