rmannibucau commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-3696062246
Hi guys, can you review it again? We just got a release and this 4 yo PR missed it. All the -1 I see are "it is bad" but we do these bad things in pretty much all plugins so tempted to say it doesn't hurt more and ultimately we delegate the "bad" impact on the user land only. I'm pushing it a bit because it enables so much cases and solve all the groovy/external-scripting issues by using java which is a big pro. In current form we just need to hack maven to grab the session by reflection which is worse IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
