sparsick commented on code in PR #346:
URL: https://github.com/apache/maven-jxr/pull/346#discussion_r2660727984
##########
maven-jxr-plugin/src/test/java/org/apache/maven/plugin/jxr/AbstractJxrTestCase.java:
##########
@@ -18,138 +18,34 @@
*/
package org.apache.maven.plugin.jxr;
+import javax.inject.Inject;
+
import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
-import java.util.Collections;
-import java.util.List;
+import java.nio.file.Paths;
-import org.apache.maven.model.Plugin;
-import org.apache.maven.plugin.LegacySupport;
-import org.apache.maven.plugin.MojoExecution;
-import org.apache.maven.plugin.descriptor.MojoDescriptor;
-import org.apache.maven.plugin.descriptor.PluginDescriptor;
-import org.apache.maven.plugin.testing.AbstractMojoTestCase;
-import org.apache.maven.plugin.testing.ArtifactStubFactory;
-import org.apache.maven.plugin.testing.stubs.MavenProjectStub;
-import org.apache.maven.project.DefaultProjectBuildingRequest;
-import org.apache.maven.project.MavenProject;
-import org.apache.maven.project.ProjectBuilder;
-import org.apache.maven.project.ProjectBuildingRequest;
-import org.eclipse.aether.DefaultRepositorySystemSession;
-import org.eclipse.aether.internal.impl.SimpleLocalRepositoryManagerFactory;
-import org.eclipse.aether.repository.LocalRepository;
-import org.junit.jupiter.api.AfterEach;
+import org.apache.maven.execution.MavenSession;
import org.junit.jupiter.api.BeforeEach;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.apache.maven.api.plugin.testing.MojoExtension.getBasedir;
/**
* Abstract class to test reports generation.
*/
-public abstract class AbstractJxrTestCase extends AbstractMojoTestCase {
- private ArtifactStubFactory artifactStubFactory;
+abstract class AbstractJxrTestCase {
Review Comment:
Only a proposal: This abstract class contains only two methods, and we have
only two test classes that use it. Therefore, I would move these two methods to
the test classes to improve the readiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
