mthmulders commented on code in PR #1571:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1571#discussion_r2669969775
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java:
##########
@@ -479,6 +502,38 @@ private Set<Artifact>
resolve(Set<org.eclipse.aether.artifact.Artifact> artifact
return resolvedArtifacts;
}
+ private Set<Artifact> collectArtifacts(MavenProject project) throws
DependencyResolutionException {
+ if (graphRoots == null || graphRoots.isEmpty()) {
+ return project.getArtifacts();
+ } else {
+ List<DependencyMatcher> filterMatchers =
+
graphRoots.stream().map(GraphRootMatcher::new).collect(Collectors.toList());
+
+ DependencyMatcher subTreeMatcher = new
OrDependencyMatcher(filterMatchers);
+
+ Set<Artifact> artifacts = new HashSet<>();
+ for (Dependency dep : project.getDependencies()) {
+ if (subTreeMatcher.matches(dep)) {
+ artifacts.addAll(resolveDependencyArtifacts(dep));
+ }
+ }
Review Comment:
Ah, makes sense. I know a way to make that work, but it's not worth the
effort if we only do it "for consistent style".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
