desruisseaux commented on issue #11612: URL: https://github.com/apache/maven/issues/11612#issuecomment-3732564412
Thanks for this work. I looked at the pull request and had only trivial comments, except two: * A project can be either fully modular or fully classical, but not a mix of both because the compiler plugin will not know how to handle that. I suggest to raise an error when such mix is detected. It impacts the `sources-mixed-modules` test. * In a modular project, I suggest to unconditionally ignore `<sourceDirectory>` and `<testSourceDirectory>` because it is not clear how to dispatch the content of those directories between the different modules. A warning should be emitted if these properties are set. It impacts the `mixed-sources` test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
