ascheman commented on code in PR #11632:
URL: https://github.com/apache/maven/pull/11632#discussion_r2688184122


##########
impl/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java:
##########
@@ -470,4 +478,255 @@ void 
testModularSourcesWithExplicitResourcesIssuesWarning() throws Exception {
         assertTrue(mainModules.contains("org.foo.moduleA"), "Should have 
resource root for moduleA");
         assertTrue(mainModules.contains("org.foo.moduleB"), "Should have 
resource root for moduleB");
     }
+
+    /**
+     * Tests mixed source configuration where:
+     * - Modular sources are defined for main Java (should override 
sourceDirectory)
+     * - Classic testSourceDirectory is used (should be preserved since no 
modular test sources)

Review Comment:
   Done in commit 63d43d5154. The test 
`testMixedSourcesModularMainClassicTest()` now verifies:
   - 2 warnings are emitted (one for `<sourceDirectory>`, one for 
`<testSourceDirectory>`)
   - Test sources are NOT added (0 test Java roots) because legacy 
`<testSourceDirectory>` is ignored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to