desruisseaux commented on issue #520:
URL:
https://github.com/apache/maven-jar-plugin/issues/520#issuecomment-3756760280
The current plugin allows the following:
```xml
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>org.foo.bar</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
```
The pull requests #521 and #522 would allow to get the same result with the
following, except for the warning when a `module-info.class` is present:
```xml
<configuration>
<automaticModuleName>org.foo.bar</automaticModuleName>
</configuration>
```
This is admittedly shorter, but is it worth to have two places for
configuring the same attribute in the plugin configuration?
If, nevertheless, there is a desire to handle the `Automatic-Module-Name`
attribute in a special way, if we want to be consistent with other attributes
that are handled in a special way such as `Main-Class`, then the attribute
would need to be added in
`org.apache.maven.shared.archiver.ManifestConfiguration`. The XML fragment
would become like below:
```xml
<configuration>
<archive>
<manifest>
<automaticModuleName>org.foo.bar</automaticModuleName>
</manifest>
</archive>
</configuration>
```
Note that this is not really shorter than the existing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
