anukalp2804 commented on code in PR #444:
URL:
https://github.com/apache/maven-build-cache-extension/pull/444#discussion_r2725700544
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -342,7 +342,7 @@ private boolean checkItemMatchesBaseline(ProjectsInputInfo
baselineBuild, Digest
private String getEffectivePom(Model prototype) throws IOException {
ByteArrayOutputStream output = new ByteArrayOutputStream();
- try (Writer writer = WriterFactory.newXmlWriter(output)) {
+ try (Writer writer = new OutputStreamWriter(output,
StandardCharsets.UTF_8)) {
new MavenXpp3Writer().write(writer, prototype);
// normalize env specifics
Review Comment:
Thanks for the review.
I’ve updated the code to write directly to the output stream and replaced
`MavenXpp3Writer`, so both deprecations are addressed together as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
