rmannibucau commented on PR #11639: URL: https://github.com/apache/maven/pull/11639#issuecomment-3809661776
> This is not a general rule. The encapsulation principle in object oriented programming recommends the opposite: do not expose implementation details unless you have to (["in case of doubt, leave it out"](https://henko.net/blog/leave-it-out/)). well what is your proposal for people using it, pom.xml is our descriptor, it is a good location to expose data. agree encapsulation is not bad - even if unrelated to OOP there - but we dont have this expose principle, exactly the one I request before we drop things. > Keeping <build> now is an unnecessary risk once again, we did drop it and had to revert it so it is not a risk but a bug. > This is not the topic of this pull request. it is totally, the topic is "what do we want to keep in consumer pom", there is no real point starting to drop random data without cleaning it all IMHO, just mean we'll have multiple breaking phases > Addressing above comment would be the topic of a separated issue in maven-jar-plugin. Think it is just your niche/JPMS case but far to be mainstream today so will not cover much sadly, so not a global solution. > See above: keeping the build is an issue, because it ties us forever for nothing I ack that but we need a solution before dropping it, so I'm -1 for this PR until we propose something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
