lalmeras opened a new pull request, #984:
URL: https://github.com/apache/maven-archetype/pull/984
Related to #983
When a multi-module project is used with create-from-project with
preserveCData, dependencies between modules are broken.
For the following hierarchy :
* A
* B
* C -> B
The built archetype replace B dependency in C module with a A dependency.
This commit adds an integration test triggering the issue and a fix.
Fix restore correctly the ${parentArtifactId} value:
* before: previous module artifactId is used (so B module setup
${parentArtifactId} B value)
* after: original value when entering the method is restored (so B module
setup ${parentArticatId} A value)
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. -> **I only write an integration
test**
- [x] Run `mvn verify` to make sure basic checks pass. -> **mvn -Prun-its
verify**
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
[x] If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
